Update round off vertex to support modification/removal #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds great! Haven't tested yet, but I'm curious how hard is it to make it work when selecting the arc segment instead of the arc center? |
src/common/common.hpp
Outdated
| @@ -268,6 +269,13 @@ template <typename T> class Coord { | |||
| { | |||
| return {x, y}; | |||
| } | |||
|
|
|||
| std::string str() const | |||
There was a problem hiding this comment.
we already have coord_to_string in geom_util.hpp
frmdstryr
force-pushed
the
modify-round-of-vertex
branch
from
d949140
to
8f49cf2
Compare
|
Sorry for not getting back to this, but you can keep the PR open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the round off vertex tool so the radius can be modified or removed by selecting the center point and re-opening the tool. If the radius is very small (eg set to 0 by editing it) it will undo the round off.
For #657.
I originally had the revert_arc function checking that the magnitude of the radii to each point are roughly the same but it seems they can be off due to rounding so that was removed. Let me know if you find any issues.